Skip to content

Conversation

@Tug
Copy link
Contributor

@Tug Tug commented Feb 11, 2019

This PR manually adds the strings that needs to be translated in gutenberg-mobile to Resources/en.lproj/Localizable.strings which will thus be added to the WordPress iOS glotpress project.

@wpmobilebot
Copy link
Contributor

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

Tug added 3 commits February 13, 2019 14:10
This PR manually adds the strings that needs to be translated in `gutenberg-mobile` to `AppStoreStrings.po` which will thus be added to the WordPress iOS glotpress project.
@Tug Tug force-pushed the add/gutenberg-mobile-strings branch from fb0d53d to 7847671 Compare February 13, 2019 13:14
@Tug Tug requested a review from koke February 13, 2019 13:16
Copy link
Member

@koke koke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The strings look good but let's leave the .gitattributes thing from 7cae164 out of this PR.

@Tug
Copy link
Contributor Author

Tug commented Feb 14, 2019

@koke I reverted that commit.

Could you check that it works on your side, it seems to be failing when I run python Scripts/localize.py now with the following error:

Error: input files have invalid format. old: /Users/tug/Work/Automattic/WordPress-iOS/WordPress/Resources/en.lproj/Localizable.strings.old, new: /Users/tug/Work/Automattic/WordPress-iOS/WordPress/Resources/en.lproj/Localizable.strings.new

Even though the file seems to be OK:

> plutil -lint WordPress/Resources/en.lproj/Localizable.strings 
WordPress/Resources/en.lproj/Localizable.strings: OK

@koke
Copy link
Member

koke commented Feb 14, 2019

I'm seeing

Bad entry in file ./Classes/ViewRelated/Post/PostSettingsViewController.m (line = 1244): Argument is not a literal string.
Error: input files have invalid format. old: /Users/koke/a8c/WordPress-iOS/WordPress/Resources/en.lproj/Localizable.strings.old, new: /Users/koke/a8c/WordPress-iOS/WordPress/Resources/en.lproj/Localizable.strings.new

Which looks like a bad call to NSLocalizedString introduced a month ago.

@wordpress-mobile/platform-9 I'm now surprised that this hasn't been a problem in the previous releases since that change was introduced for 11.7.

@Tug I think the file itself is valid, but the localize.py script expects a comment above each translation

@loremattei
Copy link
Contributor

which looks like a bad call to NSLocalizedString introduced [a month ago]

Yes! I saw it yesterday @koke and I'm setting up a PR to fix it.

I realised that the script prints a warning without returning an error in this case. Since the script is now automatically run as a part of the code_freeze lane, the warning may go unnoticed in the long log that's produced.
I'm also updating the code_freeze lane to prevent this kind of issues in the future.

@loremattei loremattei self-requested a review February 15, 2019 10:56
Copy link
Contributor

@loremattei loremattei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here look good to me. 👍

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 18, 2019

Danger run resulted in 1 warning; to find out more, see the checks page.

Generated by 🚫 dangerJS

@Tug Tug merged commit 63d7d95 into develop Feb 18, 2019
@Tug Tug deleted the add/gutenberg-mobile-strings branch February 18, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants