-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Gutenberg mobile strings for translation #10999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
8122cf2 to
ca274c6
Compare
This PR manually adds the strings that needs to be translated in `gutenberg-mobile` to `AppStoreStrings.po` which will thus be added to the WordPress iOS glotpress project.
fb0d53d to
7847671
Compare
koke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The strings look good but let's leave the .gitattributes thing from 7cae164 out of this PR.
|
@koke I reverted that commit. Could you check that it works on your side, it seems to be failing when I run Even though the file seems to be OK: |
|
I'm seeing Which looks like a bad call to @wordpress-mobile/platform-9 I'm now surprised that this hasn't been a problem in the previous releases since that change was introduced for 11.7. @Tug I think the file itself is valid, but the localize.py script expects a comment above each translation |
Yes! I saw it yesterday @koke and I'm setting up a PR to fix it. I realised that the script prints a warning without returning an error in this case. Since the script is now automatically run as a part of the |
loremattei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here look good to me. 👍
|
Danger run resulted in 1 warning; to find out more, see the checks page. Generated by 🚫 dangerJS |
This PR manually adds the strings that needs to be translated in
gutenberg-mobiletoResources/en.lproj/Localizable.stringswhich will thus be added to the WordPress iOS glotpress project.