Skip to content

Conversation

@SergioEstevao
Copy link
Contributor

Updates Gutenberg project and updates code to support MediaInfo struct to pass around media picker data.

To test:

  • Start the app
  • Create a new post using the block editor
  • Add image and video blocks check that the different sources work correctly
  • Try to copy one image from the photos app and paste inside a text block, check that an image block is added and you see an image upload simulation happening.

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 24, 2019

You can trigger an installable build for these changes by visiting CircleCI here.

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great! Approved via wordpress-mobile/gutenberg-mobile#1494 (review)

Let's not merge this PR until we have the proper gutenberg v1.15.2 tag 👍

To solve the CI issue, it might help to delete the Pods/ folder and run rake dependencies again.

EDIT: I took the liberty to commit the Podfile.lock changes and the new gutenberg commit update.

@etoledom etoledom changed the base branch from release/13.5 to gutenberg/hotfix-1.15.2 October 28, 2019 08:53
@etoledom etoledom merged commit 2b69e4c into gutenberg/hotfix-1.15.2 Oct 28, 2019
@etoledom etoledom deleted the issue/update_gutenberg_bridge branch October 28, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants