Skip to content

Conversation

@etoledom
Copy link
Contributor

@etoledom etoledom commented Oct 19, 2020

gutenberg PR: WordPress/gutenberg#26278
gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2743

This is a first step on implementing File Block.

This implementation only considers the basics:

  • Insert and render a File Block.
  • Upload a file from the iOS native Documents Picker.
    • Don't let uploading file types not allowed by the blog.
  • Edit the file name and Download button text.

The rest of features will be implemented in future PRs

EDIT: PICK A FILE has been changed to CHOOSE A FILE.
file_01

To test:

  • Add a File block.
  • Upload a file from the device.
    • Check that you are able to upload images, videos, audio, pdf... but not allowed to upload txt files.
  • Check that you can edit the file name and the Download button text.
  • Check on HTML mode that the HREF is the remote one (not local).
  • Check on preview that you can download the uploaded file.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom added the Gutenberg Editing and display of Gutenberg blocks. label Oct 19, 2020
@etoledom etoledom self-assigned this Oct 19, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 19, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 19, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@etoledom etoledom changed the title Implement File Block Implement File Block - I Oct 21, 2020
@etoledom etoledom added this to the 16.1 milestone Oct 21, 2020
@etoledom etoledom marked this pull request as ready for review October 21, 2020 07:26
@etoledom etoledom requested a review from guarani October 21, 2020 07:27
@jkmassel
Copy link
Contributor

jkmassel commented Nov 2, 2020

We're cutting 16.1 today, so this PR is being bumped to the 16.2 release. If you need it to be part of the 16.1 series, please merge it into release/16.1 and DM me – I'll be happy to create a new beta release!

@jkmassel jkmassel modified the milestones: 16.1, 16.2 Nov 2, 2020
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etoledom etoledom changed the base branch from develop to gutenberg/after_1.41.0 November 13, 2020 10:25
@etoledom etoledom added Gutenberg Editing and display of Gutenberg blocks. and removed Gutenberg Editing and display of Gutenberg blocks. labels Nov 13, 2020
@etoledom etoledom merged commit ba2c9d5 into gutenberg/after_1.41.0 Nov 13, 2020
@etoledom etoledom deleted the gutenberg/file-block branch November 13, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants