Skip to content

Enabling contact info in prod by toggling on feature flag. #16347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
illusaen merged 3 commits into from
Apr 21, 2021
Merged

Enabling contact info in prod by toggling on feature flag. #16347

illusaen merged 3 commits into from
Apr 21, 2021

Conversation

@illusaen
Copy link
Contributor

@illusaen illusaen commented Apr 21, 2021

Fixes #3395

To test:

  1. Open block inserter on site with Jetpack >= 8.5.
  2. See that contact info is in block inserter.

Regression Notes

N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 21, 2021 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@illusaen illusaen requested a review from cameronvoell April 21, 2021 06:05
@illusaen illusaen added this to the 17.3 milestone Apr 21, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 21, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@illusaen illusaen force-pushed the enable-contact-info-in-prod branch from 1a15bf2 to e38fce2 Compare April 21, 2021 08:14
@illusaen illusaen changed the base branch from develop to release/17.2 April 21, 2021 08:16
@illusaen illusaen requested a review from hypest April 21, 2021 15:38
@illusaen illusaen enabled auto-merge April 21, 2021 15:38
@illusaen illusaen merged commit faca897 into release/17.2 Apr 21, 2021
dcalhoun
dcalhoun approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on an iPhone SE. The Contact block showed up in the block inserter as expected. 🎉

@illusaen illusaen deleted the enable-contact-info-in-prod branch April 21, 2021 16:13
@hypest hypest mentioned this pull request Apr 23, 2021
Closed
@dcalhoun dcalhoun modified the milestones: 17.3, 17.2 ❄️ Apr 23, 2021
@enejb enejb mentioned this pull request May 20, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

@cameronvoell cameronvoell Awaiting requested review from cameronvoell

@hypest hypest Awaiting requested review from hypest

Assignees

No one assigned

Labels

[Type] Bug

Projects

None yet

Milestone

17.2

Development

Successfully merging this pull request may close these issues.

Contact Info Block: Not shown in "add block" bottom sheet

3 participants

@illusaen @dcalhoun