-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Bundle local static React Native assets #16967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle local static React Native assets #16967
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Now that we are attempting to load local static image assets in the React Native bundle, we must copy those assets for them to properly show up in the WordPress iOS app.
f0b6bad to
eb915c9
Compare
ceyhun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dcalhoun! Tested it with the WordPress target with debug config and it's working great! Do you think maybe we should add the same change to Jetpack target as well?
Also maybe we can trigger the installable builds to verify if it builds correctly on CI with release config for both targets.
I had not considered that. Based on my understanding of how the Jetpack app also consumes Gutenberg, I would imagine we should update Jetpack's target as well. I will do that. Thank you!
Great idea. I started a CI task now to create one. |
Now that we are attempting to load local static image assets in the React Native bundle, we must copy those assets for them to properly show up in the WordPress iOS app.
|
@ceyhun I updated the Jetpack target configuration to match, and verified the images loaded via a build with Xcode. Additionally, I created installable builds for both WordPress and Jetpack; those are attached to this PR. Ready for another review when you have time. Thanks! |
ceyhun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that both builds have the images. Thanks David!
Now that we attempt to load local static image assets in the React Native bundle in WordPress/gutenberg#33790, we must copy those assets for them to properly show up in the WordPress iOS app build.
To test:
Screenshot of Help Image
Regression Notes
Modifications to the build configuration could cause the build process to fail.
Verified the Debug build succeeded.
I do not believe this could/should be tested with automation, as build failures should be fairly obvious.
PR submission checklist:
RELEASE-NOTES.txtif necessary.