Merge editorialized release notes for 18.2 #17131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The one from ce0ed56 was the wrong one 🤦♂️
I've done the `msgid` bugfix real-world testing I wanted to do. Now switching back to the expected version.
|
You can trigger an installable build for these changes by visiting CircleCI here. |
mokagio
commented
Sep 8, 2021
| faraday (>= 0.9) | ||
| sawyer (~> 0.8.0, >= 0.5.3) | ||
| oj (3.13.1) | ||
| oj (3.13.4) |
Contributor
Author
There was a problem hiding this comment.
These gems patch version changes are a byproduct of my dance with the release toolkit version. They snuck in there because I had to go through two versions, so instead of git revert two commits I manually rolled back the Pluginfile and run bundle update fastlane-plugin-wpmreleasetoolkit.
I don't think they present any issue, so I decided not to spend any extra time to amend them.
Generated by 🚫 dangerJS |
oguzkocer
approved these changes
Sep 8, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please forgive the long commit history. I was curious to try my
msgidfix, which is merged in the release toolkitdevelopbut hasn't been release yet, in another codebase but pointed totrunkinstead ofdevelopand, becauseupdate_appstore_stringspushes, I didn't have a chance to rebase the mistake away. FWIW, 69e4335 and confirm 7b3ecb5 one more time that the fix is legit.