-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix/15651 - Followed sites in Reader > Following > Filter #17173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
|
👋 @ScoutHarris I'm tagging you here since you've worked on the issue. It would be great if you could take a look at this and point out any potential unintended areas of impact, since I'm not aware of any, and it was all good in my testing environment. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
momo-ozawa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described! I'll defer approval to @ScoutHarris, just in case there's any unintended areas of impact 🙏
|
Sorry I didn't get to this yesterday! Not sure the history of excluding external sites before, but I see no reason not to now. So 👍 from me. (Also FYI - the UI tests will be fixed with this change.) |
|
@nikola-milicevic I went ahead and merged this so it would make the release. |
|
@ScoutHarris Great, thanks! 😊 |
Part of #15651
Description
This PR fixes the Followed sites list in Reader > Following > Filter.
Screenshots
To test:
Regression Notes
Potential unintended areas of impact
Not sure.
What I did to test those areas of impact (or what existing automated tests I relied on)
n/a
What automated tests I added (or what prevented me from doing so)
n/a
PR submission checklist:
RELEASE-NOTES.txtif necessary.