-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove obsolete Core Data models #25124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+7
−53,867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
4ad229f to
1fdc749
Compare
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30396 | |
| Version | PR #25124 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 55ca2ce | |
| Installation URL | 60fcjtlbb40pg |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30396 | |
| Version | PR #25124 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 55ca2ce | |
| Installation URL | 32h2un2phb0q0 |
Contributor
Author
|
Looks like I need to remove some obsolete tests as well. |
crazytonyli
approved these changes
Jan 11, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.





Similarly to the work Woo Mobile has done, I suggest removing obsolete Core Data models.
The cut-off data is 2020-10-05 (version 99), which should be safe enough. The chances that there is someone with a five year old app is close to zero.
This change reduces the app size by ~6.4 MB (13.4 MB → 7.8 MB). It should also slightly reduce the compile time (minus 54K lines of Core Data XML that needs to be compiled to code).
I'm not aware of any negative side effects of removing models that are no longer used. The remaining migration tests guarantee that migrations for models after 100 still work.