Skip to content

Conversation

@kean
Copy link
Contributor

@kean kean commented Jan 8, 2026

Similarly to the work Woo Mobile has done, I suggest removing obsolete Core Data models.

The cut-off data is 2020-10-05 (version 99), which should be safe enough. The chances that there is someone with a five year old app is close to zero.

This change reduces the app size by ~6.4 MB (13.4 MB7.8 MB). It should also slightly reduce the compile time (minus 54K lines of Core Data XML that needs to be compiled to code).

I'm not aware of any negative side effects of removing models that are no longer used. The remaining migration tests guarantee that migrations for models after 100 still work.

@kean kean added this to the 26.6 milestone Jan 8, 2026
@kean kean added the General label Jan 8, 2026
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@kean kean force-pushed the task/remove-older-core-data-models branch from 4ad229f to 1fdc749 Compare January 8, 2026 16:27
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 8, 2026

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number30396
VersionPR #25124
Bundle IDcom.jetpack.alpha
Commit55ca2ce
Installation URL60fcjtlbb40pg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 8, 2026

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number30396
VersionPR #25124
Bundle IDorg.wordpress.alpha
Commit55ca2ce
Installation URL32h2un2phb0q0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@kean kean requested a review from crazytonyli January 8, 2026 17:21
@kean
Copy link
Contributor Author

kean commented Jan 9, 2026

Looks like I need to remove some obsolete tests as well.

@sonarqubecloud
Copy link

@kean kean added this pull request to the merge queue Jan 12, 2026
Merged via the queue into trunk with commit 4f3a8eb Jan 12, 2026
26 of 32 checks passed
@kean kean deleted the task/remove-older-core-data-models branch January 12, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants