This repository was archived by the owner on Jul 8, 2022. It is now read-only.
Add organization_id value to WP.com /me/sites stub
#35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to the changes in: - wordpress-mobile/WordPressKit-iOS#445 - wordpress-mobile/WordPress-iOS#17154 By looking at the changes in the PRs listed above, I'm guessing the key has been in the response from the live API for a while, but we never updated this particular mock response because we hadn't needed the value till now. I noticed that the Jetpack version of me/sites does include `organization_id`, so we can say that the value had been in the response at least since May 2021. See caa9d47
1 task
diegoreymendez
approved these changes
Sep 17, 2021
diegoreymendez
left a comment
diegoreymendez
left a comment
There was a problem hiding this comment.
The changes looks good on my end.
Thanks @mokagio !
mokagio
added a commit
that referenced
this pull request
Sep 20, 2021
Note that in this instance we are not going through a beta because today is also code freeze for WordPress iOS and I just merged the PR, #35, that required this new version. Basically, I'm taking a shortcut and not releasing a beta because I would override that beta with a stable version immediately.
mokagio
added a commit
to wordpress-mobile/WordPress-iOS
that referenced
this pull request
Sep 20, 2021
Now that wordpress-mobile/WordPressMocks#35 has been merged and a new version shipped, we can point away from the WIP branch and back to a stable version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to the changes in:
By looking at the changes in the PRs listed above, I'm guessing
organization_idhas been in the response from the live API for a while, but we never updated this particular mock response because we hadn't needed the value till now.In fact, I noticed that the Jetpack
/me/sitesversion does includeorganization_id, so we can say that the value had been in the response at least since May 2021. See caa9d47To Test
See wordpress-mobile/WordPress-iOS#17177 and notice that the UI tests pass in both Buildkite and CircleCI. The reason for the failures we've seen before this was that the tests crashed when trying to assign the
nilvalue stored in theorganizationIdproperty serialized from the stub response that didn't include the key.