Fix eslint missing src subdirs #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add `prettier-eslint-cli` which is needed for running Prettier from the command line (and the `prettier` yarn script).
etoledom
approved these changes
Aug 13, 2018
Contributor
etoledom
left a comment
etoledom
left a comment
There was a problem hiding this comment.
Nice catch and great additions! 🎉
All commands mentioned worked perfectly and gave a clean output ✅
hypest
added a commit
that referenced
this pull request
Jan 3, 2019
Point to Aztec with fix for backspace on paste
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The params passed to eslint command line specifying which source files to check were missing the subdirectories inside the
srcdirectory. See this comment for example. This PR replaces the glob definition with the all-catching..The submodules are left out of the list though (see
.eslintignorefile) since those are checked in their respective repositories.Also in this PR:
yarn prettiercommand to useprettier-eslint-cli@flowpragma to more source files so Flow should check those tooTo test:
yarn lint) and tests (yarn test); all should run fine as wellyarn flow); no warnings/errors should be emittedyarn prettier) which also should run fine and introduce no changes to the code filesyarn lint:fix) which also should run fine and introduce no changes to the code files