HTML parser - restart datasource after full parse of html #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs a
dataSourcere-init (by recreating the object in thestate) when a fullparsehas taken place. While we've avoided re-creating the list'sdataSourcein other cases, I think it makes sense to do so after an html-to-blocks conversion has taken place.This makes sure the state of
dataSource, andpropsare aligned, and fixes the detail described in #100 here:To test (on Android):
Idea to make this better at some point in the future: only pass the
fullparse: truevalue when no edits have been in place (maybe at least check the length?)