Inserter - block icons #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Contributor
|
It's a quite simplified version comparing to web :) |
SergioEstevao
approved these changes
Aug 24, 2018
Contributor
SergioEstevao
left a comment
SergioEstevao
left a comment
There was a problem hiding this comment.
The icons are looking great, feel free to merge when you have the GB side PR approved.
Contributor
Author
|
Thank you @SergioEstevao ! 🙇 |
5 tasks
Contributor
|
Awesome to see this landed 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the block icons visible in the
BlockPicker:To test:
+iconRelies on the following Gutenberg PR WordPress/gutenberg#9294