Skip to content

Conversation

@lukewalczak
Copy link
Contributor

@lukewalczak lukewalczak commented Oct 2, 2019

Fixes #1384
Ref to gutenberg: WordPress/gutenberg#17703

To test:

  1. Add an image.
  2. Press and icon
  3. Check the BlockSettings inspector

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@pinarol pinarol requested a review from koke October 2, 2019 11:56
@pinarol pinarol added the [Status] Needs Design Review Needs design review or sign-off before shipping label Oct 2, 2019
@iamthomasbishop
Copy link
Contributor

I gave a thorough design review over here. Let me know if I missed anything or when another review is needed!

Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@lukewalczak lukewalczak merged commit 8063720 into develop Oct 18, 2019
@lukewalczak lukewalczak deleted the callstack/rnmobile/grouping-block-settings branch October 18, 2019 11:41
daniloercoli added a commit that referenced this pull request Oct 21, 2019
…rg-mobile into issue/wp-android-8828-Aztec-crash-Android-8

* 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: (24 commits)
  Feat: cover cross platform RangeControl (#1342)
  Introduce grouping in the block settings inspector (#1397)
  Fix native test of image block (#1456)
  Update RELEASE notes with iOS11 and Swift 5 update
  Expose WordPressUtils for consumption by gutenberg-bridge
  Update Aztec-Android ref to v1.3.33
  Update bundles
  revert missing toggle editor mode call (#1444)
  Update Aztec-iOS ref to 1.11.0
  Update Aztec-Android ref to v1.3.32
  Update Aztec-iOS ref
  Update bundles
  Bump version to 1.15.0
  Update Gutenberg
  Add Media & Text block to initial HTML
  Update Gutenberg
  Updated bundles
  Update Gutenberg
  Update Gutenberg
  Update gutenberg
  ...

# Conflicts:
#	react-native-aztec/android/build.gradle
daniloercoli added a commit that referenced this pull request Oct 23, 2019
…rg-mobile into issue/wp-android-9832-IndexOutOfBoundsException-setSpan

* 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile:
  Bump version to 1.15.1
  Update bundles
  Update Aztec to the new tagged version v1.3.34
  Feat: cover cross platform RangeControl (#1342)
  Introduce grouping in the block settings inspector (#1397)
  Fix native test of image block (#1456)

# Conflicts:
#	react-native-aztec/android/build.gradle
pinarol pushed a commit that referenced this pull request Oct 28, 2019
* Fix native test of image block (#1456)

* Add ref to gutenberg repo

* Update ret to point to master

* Introduce grouping in the block settings inspector (#1397)

* Feat: cover cross platform RangeControl (#1342)

* feat: add RangeCell component

* update ref

* update ref and bundle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Design Review Needs design review or sign-off before shipping

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce grouping in the Block Settings Inspector

5 participants