Fix Android html text input #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps the html TextInput on Android to be editable and change its state properly.
Contributor
Yes, that would actually be useful since there are moving parts all over the place in BlockManager, especially now that it seems the different mobile platforms demand different implementations. You think you can work on that in this PR? If not, happy to have it in a separate PR. Otherwise, I tested this PR until this point and I can confirm it fixes the regression on Android. iOS continues to work as well. |
Contributor
Author
|
Thank you @hypest ! I'll merge this to fix the issue on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the html text input that stoped responding to changes on Android.
On iOS:
If the html string is stored on the state and it changes, the whole TextInput is recreated, making jump on certain circumstances. (ref: #115)
On Android:
If the html string is not stored on the component's state, the state of the TextInput won't change even when the user tries. In other words, #115 broke Android's html TextInput.
This solution implements a different way to hold and get the html string for iOS and Android.
HTMLTextInputcomponent that handles this problem internally, but I prefer to ask for suggestions before implementing it.