Fix: Group appender behaviour #1588
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
lukewalczak
force-pushed
the
callstack/fix-group-appender
branch
from
d54e25e to
ac7a3b2
Compare
hypest
approved these changes
Dec 18, 2019
Contributor
hypest
left a comment
hypest
left a comment
There was a problem hiding this comment.
LGTM!
Feel free to update the Gutenberg ref to the merged one when the Gutenberg PR gets merged and then merge this PR too.
I'd probably suggest reverting the bundle and map files to avoid the conflicts anyway.
Contributor
|
Seems like it this PR is not necessary anymore since the gutenberg ref was updated by other PRs. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes group appender behaviour
Please also refer to:
Related gutenberg PR
Update release notes:
RELEASE-NOTES.txt.