Skip to content

[iOS] Remove xcworkspace. #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
etoledom merged 1 commit into from
Jan 22, 2020
Merged

[iOS] Remove xcworkspace. #1797

etoledom merged 1 commit into from
Jan 22, 2020

Conversation

@etoledom
Copy link
Contributor

@etoledom etoledom commented Jan 21, 2020 •
edited
Loading

xcworkspace dir makes UITests to fail.

To test:

  • All tests should pass.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@etoledom
[iOS] Remove xcworkspace.
63c73b2 
xcworkspace dir makes UITests to fail.
@etoledom etoledom added this to the 1.21 milestone Jan 21, 2020
@etoledom etoledom self-assigned this Jan 21, 2020
SergioEstevao
SergioEstevao approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@etoledom etoledom merged commit bc83e25 into release/1.21.0 Jan 22, 2020
@etoledom etoledom deleted the issue/remove-ios-xcworkspace branch January 22, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees

@etoledom etoledom

Labels

Tooling

Projects

None yet

Milestone

1.21

Development

Successfully merging this pull request may close these issues.

3 participants

@etoledom @SergioEstevao