Skip to content

Correct layout within bottom-sheet [workaround] #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukewalczak merged 28 commits into from
Feb 12, 2020
Merged

Correct layout within bottom-sheet [workaround] #1837

lukewalczak merged 28 commits into from
Feb 12, 2020

Conversation

@lukewalczak
Copy link
Contributor

@lukewalczak lukewalczak commented Jan 30, 2020 •
edited
Loading

Fixes #1404

Ref to gutenberg PR: WordPress/gutenberg#18574

To test:

1.Run the app on a smaller device or on the regular in horizontal mode
2.User should be able to scroll through all the blocks / add them
3.Please check also other bottom-sheets in the app e.g: Image settings

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@pinarol pinarol added this to the 1.22 milestone Jan 30, 2020
@lukewalczak lukewalczak mentioned this pull request Jan 30, 2020
Merged
6 tasks
@lukewalczak lukewalczak force-pushed the bottom-sheet-workaround branch from f2e53cb to e7ff116 Compare January 30, 2020 17:09
@etoledom etoledom self-requested a review January 31, 2020 12:08
@etoledom etoledom added [Type] Enhancement Improves a current area of the editor bugfix labels Jan 31, 2020
@lukewalczak lukewalczak added the help wanted Extra attention is needed label Feb 4, 2020
@lukewalczak lukewalczak force-pushed the bottom-sheet-workaround branch from 2558dba to 1d03263 Compare February 5, 2020 09:49
@lukewalczak lukewalczak removed the help wanted Extra attention is needed label Feb 6, 2020
etoledom
etoledom approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#18574 (review)

Great job! 🎉

@etoledom etoledom modified the milestones: 1.22, 1.23 Feb 10, 2020
@lukewalczak lukewalczak merged commit 7aa4ed1 into develop Feb 12, 2020
@lukewalczak lukewalczak deleted the bottom-sheet-workaround branch February 12, 2020 11:42
@etoledom etoledom mentioned this pull request Feb 14, 2020
Closed
This was referenced Feb 17, 2020
Merged
Merged
Merged
@designsimply designsimply mentioned this pull request Aug 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@etoledom etoledom etoledom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukewalczak lukewalczak

Labels

bugfix [Type] Enhancement Improves a current area of the editor

Projects

None yet

Milestone

1.23

Development

Successfully merging this pull request may close these issues.

Inserter shows wrong layout with Display Zoom enabled

4 participants

@lukewalczak @etoledom @pinarol