Skip to content

Fix replacing empty paragraph in inner block #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dratwas merged 1 commit into from
Mar 12, 2020
Merged

Fix replacing empty paragraph in inner block #1984

dratwas merged 1 commit into from
Mar 12, 2020

Conversation

@dratwas
Copy link
Contributor

@dratwas dratwas commented Mar 5, 2020

Fixes #1974

Gutenberg PR: WordPress/gutenberg#20653

To test:

  • Open an empty editor w/o any block in it.
  • Add Cover/Group block
  • Add empty paragraph inside the created block
  • Make sure that the created paragraph is empty and selected
  • Click on the "Add block" button and select some block
  • The paragraph should be replaced by selected block
  • PR submission checklist:
Before After
cover-issue cover-issue-after
  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dratwas dratwas mentioned this pull request Mar 5, 2020
Merged
6 tasks
@pinarol pinarol requested a review from jbinda March 9, 2020 09:21
jbinda
jbinda reviewed Mar 9, 2020
View reviewed changes
Copy link
Contributor

@jbinda jbinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with sanity-test cases and it seems to work as expected.

@jbinda jbinda self-requested a review March 9, 2020 13:22
@dratwas dratwas force-pushed the fix/inserter-in-inner-block branch from 5d2b2b6 to 4ccd3c3 Compare March 12, 2020 16:33
@dratwas dratwas merged commit c76eb1b into develop Mar 12, 2020
@dratwas dratwas deleted the fix/inserter-in-inner-block branch March 12, 2020 16:57
@pinarol pinarol mentioned this pull request Mar 25, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jbinda jbinda jbinda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adding a new block inside other block that is the only block in editor removes the whole parent block

3 participants

@dratwas @jbinda