Skip to content

Conversation

@dratwas
Copy link
Contributor

@dratwas dratwas commented Mar 23, 2020

Fixes #1948
Gutenberg PR - WordPress/gutenberg#20769
To test:

  • App should look exactly the same as before.
  • Please focus on checking borders of selected/unselected blocks in inner blocks

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with the steps in the gutenberg PR.

@dratwas dratwas force-pushed the block-borders-reimplementation branch from cae5840 to 0f6f52b Compare March 25, 2020 14:16
@dratwas dratwas merged commit 3772fcf into develop Mar 25, 2020
@dratwas dratwas deleted the block-borders-reimplementation branch March 25, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Try: Absolutely positioned frame view approach to simplify the logic for border/space calculations of InnerBlocks

3 participants