Enable cover block uploads behind dev flag #2070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 27, 2020
3 tasks
chipsnyder
approved these changes
Mar 31, 2020
Contributor
chipsnyder
left a comment
chipsnyder
left a comment
There was a problem hiding this comment.
LGTM:
Approved with:
WordPress/gutenberg#21196 (review)
WordPress/gutenberg#21197 (review)
geriux
approved these changes
Apr 6, 2020
Contributor
geriux
left a comment
geriux
left a comment
There was a problem hiding this comment.
Approved via WordPress/gutenberg#21196 (comment)
mkevins
deleted the
feature/cover-block-uploads-enable-dev-only-and-progress
branch
Contributor
Author
|
🎉 Thanks for testing and reviewing 👍 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the first step toward resolving #1739. This PR enables upload options for the Cover block behind the
__DEV__flag, and adds a progress bar to ongoing uploads. More details can be found within the individualgutenbergPRs.Related PRs:
gutenbergWordPress-Android: Cover block upload completion processor WordPress-Android#11541WordPress-iOS: [Testing] Enable cover block uploads behind dev flag WordPress-iOS#13769To test:
Testing steps are provided in the related
gutenbergPRs.PR submission checklist:
RELEASE-NOTES.txtif necessary.