Skip to content

Introducing LinkSettings component #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lukewalczak wants to merge 6 commits into from
Closed

Introducing LinkSettings component #2406

lukewalczak wants to merge 6 commits into from

Conversation

@lukewalczak
Copy link
Contributor

@lukewalczak lukewalczak commented Jun 19, 2020 •
edited
Loading

Fixes #

Ref to gutenberg: WordPress/gutenberg#23299

To test:

Go through test steps Button-6 and Button-7 from sanity-tests

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 19, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@lukewalczak lukewalczak self-assigned this Jun 19, 2020
@geriux geriux self-requested a review June 24, 2020 11:44
@geriux geriux added the [Type] Enhancement Improves a current area of the editor label Jun 24, 2020
@geriux geriux added this to the 1.32 milestone Jun 24, 2020
@lukewalczak lukewalczak mentioned this pull request Jun 24, 2020
Merged
6 tasks
geriux
geriux approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved via WordPress/gutenberg#23299 (comment)

@mchowning
Copy link
Contributor

mchowning commented Jul 7, 2020 •
edited
Loading

👋 @lukewalczak ! We're getting ready to cut the 1.32 release branch. If this needs to make that release, please merge this as soon as possible. Otherwise, please update the milestone to 1.33. Thanks! 🙇

UPDATE: I decided to go ahead and bump the milestone to 1.33. If this does need to make 1.32, feel free to undo that change and let us know in Slack that this needs to make the 1.32 release.

@mchowning mchowning modified the milestones: 1.32, 1.33 Jul 7, 2020
@geriux
Copy link
Contributor

geriux commented Jul 8, 2020

This was already merged in Gutenberg repo so since this is only updating the commit reference I think we could close it, what do you think @lukewalczak ?

@lukewalczak
Copy link
Contributor Author

lukewalczak commented Jul 8, 2020 •
edited
Loading

I've realized that it's already merged within Gutenberg. We can close it and change the milestone into 1.32. Thanks @geriux !

@lukewalczak lukewalczak closed this Jul 8, 2020
@lukewalczak lukewalczak modified the milestones: 1.33, 1.32 Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@geriux geriux geriux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukewalczak lukewalczak

Labels

[Type] Enhancement Improves a current area of the editor

Projects

None yet

Milestone

1.32

Development

Successfully merging this pull request may close these issues.

4 participants

@lukewalczak @mchowning @geriux