Media editing - Show button for invalid images #2623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
antonis
approved these changes
Sep 16, 2020
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
Approved with WordPress/gutenberg#25366
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg PR-> WordPress/gutenberg#25366Fixes WordPress/gutenberg#25347
When the media editing option was introduced to the Gallery block the
Removebutton was replaced for this one instead. By doing that the remove option was moved into the media editing options.This PR removes a check to prevent rendering the media edit button if the image data is not loaded, this way the options
Remove(for gallery) andReplaceforImage,Media & Text, andCoverare available.To test check the Gutenberg PR.
PR submission checklist: