-
Notifications
You must be signed in to change notification settings - Fork 57
Add ability to toggle html/visual modes through the bridge #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # src/block-management/block-manager.js
|
I pushed a commit that gets rid of the extra padding at the top, which wasn't that noticeable before, but looked weird without the toggles |
…gutenberg-mobile into feature/switch-to-html
|
I tested this and works great, iOS code looks good as well. |
This reverts commit a587f7a.
…gutenberg-mobile into feature/switch-to-html
…gutenberg-mobile into feature/switch-to-html
…gutenberg-mobile into feature/switch-to-html
etoledom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @pinarol ! It looks super good and it's working flawlessly 🎉
I got one question as code comments sections, but whatever is the answer I'm happy to ✅ and
!
|
A little note @hypest . |
|
It would be good also, at this point, to bundle a new App.js file, since the current one is quite outdated and WPiOS won't recognize the new bridge message without this code. But it could be on a follow up PR too. 👍 |
…gutenberg-mobile into feature/switch-to-html
|
I'll be pushing a new version of the bundle tomorrow with all the latest changes |
This change adds switch to html/visual mode messaging to the bridge and demonstrates it on the example app.
On RN side: Updates the BlockManager to handle TOGGLE_BLOCK_MODE updates and re-render its contents.
Part of #182
To Test
Test 1:
Test 2:
Test 3:
Also: