Focus on RichText when selection changes #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2018
Member
Author
|
@mzorz since you probably have a better idea of the current issues, feel free to add any this PR fixes to the description |
Contributor
|
Nothing much to add 😄 the code is quite simple to read and you got things right. |
mzorz
approved these changes
Nov 29, 2018
Contributor
mzorz
left a comment
mzorz
left a comment
There was a problem hiding this comment.
LGTM - let's update the Gutenberg hash here once WordPress/gutenberg#12422 lands
11 tasks
…g-mobile into issue/rich-text-focus-on-selection * 'master' of https://github.com/wordpress-mobile/gutenberg-mobile: Update GB ref to point to master Create blocks empty by default Update GB hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines WordPress/gutenberg#12422 and wordpress-mobile/react-native-aztec#85
When a RichText becomes selected, it will call
focuson the aztec view to ensure it gets the right focus. The focus was working OK when tapping, but this fixes the cases where the block focus changes programatically, like inserting a new paragraph or splitting a block.To test: