Fix SVG styling #322
Merged
Fix SVG styling #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tug
commented
Dec 5, 2018
| integrity sha512-41qEJgBH/TWgo5NFSvBCJ1qkoi3Q6ONSF2avrHq1LVEZfYpdHmj0y9SuTK+u9ZhG1sYQKBL1AWXKyLWP4RaUoQ== | ||
|
|
||
| "@wordpress/babel-plugin-import-jsx-pragma@file:gutenberg/packages/babel-plugin-import-jsx-pragma": | ||
| "@wordpress/babel-plugin-import-jsx-pragma@^1.1.2": |
Contributor
Author
There was a problem hiding this comment.
looks like yarn.lock is not up to date in master, let's update it!
Contributor
|
Hey @Tug , there are some conflicts on this branch. |
Contributor
Author
|
Yeah I'll just update |
marecar3
approved these changes
Dec 6, 2018
Contributor
marecar3
left a comment
marecar3
left a comment
There was a problem hiding this comment.
Tested on both iOS and Android and it's working :)
Approeved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #320
Requires WordPress/gutenberg#12608
This PR fixes a regression on SVG styling I introduced in #310.
Testing Instructions