Fix ShouldInsertAtTheTop setting calculation
#3538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
Contributor
Author
|
All tests (including optional) were 🟢 in the previous commit to the update with the merge commit. |
geriux
approved these changes
May 24, 2021
Contributor
geriux
left a comment
geriux
left a comment
There was a problem hiding this comment.
Approved via WordPress/gutenberg#32110 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenbergPR: WordPress/gutenberg#32110Fixes the issue identified after merging the reusable block PR into
develop(UI test reference).To test:
Follow testing instructions from Gutenberg PR.
PR submission checklist: