Skip to content

Scroll header toolbar to end when RTL #3923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hypest merged 9 commits into from
Sep 10, 2021
Merged

Scroll header toolbar to end when RTL #3923

hypest merged 9 commits into from
Sep 10, 2021

Conversation

@hypest
Copy link
Contributor

@hypest hypest commented Sep 7, 2021 •
edited
Loading

Fixes #3889

Related PRs

To test

  1. Set the device/emulator to an RTL language like Hebrew
  2. Run the demo app on a device narrow enough to not be able to show the main toolbar when a text block is selected
  3. Tap to select a text block(for instance, paragraph or header) in the demo content
  4. Notice that the main toolbar scrolls to reveal the inserter button. See the video in the GB PR as an example.

PR submission checklist

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@hypest hypest mentioned this pull request Sep 7, 2021
Merged
7 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 7, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@hypest hypest requested a review from SiobhyB September 7, 2021 11:55
SiobhyB
SiobhyB approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#34617 (review)

SiobhyB
SiobhyB approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#34617 (review), with a similar small suggestion/question for the RELEASE-NOTES, but no blockers.

@hypest hypest enabled auto-merge September 10, 2021 16:11
@hypest hypest merged commit a0f0173 into develop Sep 10, 2021
@hypest hypest deleted the issue/3889-fix-header-toolbar-init-when-rtl branch September 10, 2021 16:17
@enejb enejb mentioned this pull request Sep 17, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SiobhyB SiobhyB SiobhyB approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RTL: "+" icon not in view when paragraph block is focused

3 participants

@hypest @SiobhyB