Use i18n update script when generating JS bundle

.buildkite/pipeline.yml

@@ -17,6 +17,9 @@ steps:
           image: "public.ecr.aws/automattic/gb-mobile-image:latest"
           environment:
             - "CI=true"
+            # Allow WP-CLI to be run as root, otherwise it throws an exception.
+            # Reference: https://git.io/J9q2S
+            - "WP_CLI_ALLOW_ROOT=true"
     command: |
         source /root/.bashrc
 

.circleci/config.yml

@@ -21,7 +21,7 @@ commands:
           key: npm-i18n-v5-cache-v{{ .Environment.CACHE_TRIGGER_VERSION }}-job-{{ .Environment.CIRCLE_JOB }}-{{ checksum "package-lock.json" }}
           paths:
             - ~/.npm
-            - i18n-cache/data
+            - src/i18n-cache
   npm-install-full:
     steps:
       - restore_cache:
@@ -39,7 +39,7 @@ commands:
           key: npm-i18n-v5-cache-v{{ .Environment.CACHE_TRIGGER_VERSION }}-job-{{ .Environment.CIRCLE_JOB }}-{{ checksum "gutenberg/package-lock.json" }}
           paths:
             - ~/.npm
-            - i18n-cache/data
+            - src/i18n-cache
   checkout-shallow:
     steps:
       - run:

.gitignore

@@ -120,3 +120,6 @@ bin/wp-cli.phar
 
 ios/Pods
 ios/vendor
+
+# i18n update
+i18n-test/

bin/i18n-check-cache.sh

@@ -0,0 +1,68 @@
+#!/bin/bash
+# 
+# Checks i18n cache folders in order to guarantee that translations are present for provided plugins.
+# A cache folder will be created, in case a plugin doesn't have it, with its translations that 
+# will be fetched before creation.
+#
+# NOTE: The translations fetched are NOT OPTIMIZED, the reason for this is purely for making
+# the script fast as it will be mainly used upon dependency installation.
+
+# Exit if any command fails
+set -euo pipefail
+
+function error() {
+  echo -e "\033[0;31m$1\033[0m"
+  exit 1
+}
+
+function arrayLength() { echo "$#"; }
+
+function check_plugin_cache() {
+  local plugin_name=$1
+  local i18n_cache_folder="$TRANSLATIONS_OUTPUT_PATH/$plugin_name"
+
+  if [[ ! -d $i18n_cache_folder ]]; then
+    NOT_FOUND_PLUGIN_I18N_CACHE+=( $i18n_cache_folder )
+    echo -e "Couldn't find i18n cache folder (\"$i18n_cache_folder\") for plugin \"$plugin_name\", downloading un-optimized translations for creating the cache."
+    fetch_translations "$plugin_name" "$TRANSLATIONS_OUTPUT_PATH"
+  fi
+}
+
+function update_gutenberg_i18n_cache() {
+  local output_path=$1
+
+  echo "Update \"react-native-editor\" package i18n cache"
+  cp -r "$output_path/gutenberg/data" gutenberg/packages/react-native-editor/i18n-cache
+  cp "$output_path/gutenberg/index.js" gutenberg/packages/react-native-editor/i18n-cache/index.native.js
+}
+
+function fetch_translations() {
+  local plugin_name=$1
+  local output_path=$2
+
+  echo -e "\n\033[1mDownload I18n translations for \"$plugin_name\" plugin\033[0m"
+  node gutenberg/packages/react-native-editor/bin/i18n-translations-download "$plugin_name" "$output_path"
+}
+
+# Get parameters
+PLUGINS=( "$@" )
+
+# Define constants
+TRANSLATIONS_OUTPUT_PATH="src/i18n-cache"
+
+echo -e "\n\033[1m== Checking i18n cache ==\033[0m"
+
+# Check plugins cache
+for PLUGIN in "${PLUGINS[@]+"${PLUGINS[@]}"}"; do
+  check_plugin_cache "$PLUGIN"
+done
+
+# Check Gutenberg cache
+check_plugin_cache "gutenberg"
+
+if [[ $(arrayLength "${NOT_FOUND_PLUGIN_I18N_CACHE[@]+"${NOT_FOUND_PLUGIN_I18N_CACHE[@]}"}") -eq 0 ]]; then
+  echo -e "i18n cache for provided plugins is present ✅"
+fi
+
+# We need to guarantee that i18n cache within react-native-editor package is updated
+update_gutenberg_i18n_cache "$TRANSLATIONS_OUTPUT_PATH"

bin/i18n-update.sh

@@ -27,20 +27,15 @@ while test $# -gt 0; do
   case "$1" in
     -h|--help)
       echo "options:"
-      echo "-h, --help    show brief help"
-      echo "-p, --path    local path for generating files (by default a temp folder will be used)"
-      echo "-d, --debug   print extra info for debugging"
+      echo "-h, --help              show brief help"
+      echo "-p, --path              local path for generating files (by default a temp folder will be used)"
       exit 0
       ;;
     -p|--path*)
       shift
       LOCAL_PATH=$1
       shift
       ;;
-    -d|--debug*)
-      shift
-      DEBUG='true'
-      ;;
     *)
       break
       ;;
@@ -54,6 +49,23 @@ function error() {
 
 function arrayLength() { echo "$#"; }
 
+function check_plugin() {
+  local plugin_folder=$1
+
+  if [[ ! -d $plugin_folder ]]; then
+    NOT_FOUND_PLUGIN_FOLDERS+=( $plugin_folder )
+    echo -e "\033[0;31mPlugin folder \"$plugin_folder\" doesn't exist.\033[0m"
+  fi
+}
+
+function update_gutenberg_i18n_cache() {
+  local output_path=$1
+
+  echo "Update \"react-native-editor\" package i18n cache"
+  cp -r "$output_path/gutenberg/data" gutenberg/packages/react-native-editor/i18n-cache
+  cp "$output_path/gutenberg/index.js" gutenberg/packages/react-native-editor/i18n-cache/index.native.js
+}
+
 function fetch_translations() {
   local plugin_name=$1
   local output_path=$2
@@ -63,9 +75,7 @@ function fetch_translations() {
   node gutenberg/packages/react-native-editor/bin/i18n-translations-download "$plugin_name" "$output_path" "$used_strings_file"
 
   if [[ "$plugin_name" == "gutenberg" ]]; then
-    echo "Update \"react-native-editor\" package i18n cache"
-    cp -r "$output_path/gutenberg/data" gutenberg/packages/react-native-editor/i18n-cache
-    cp "$output_path/gutenberg/index.js" gutenberg/packages/react-native-editor/i18n-cache/index.native.js
+    update_gutenberg_i18n_cache "$output_path"
   fi
 }
 
@@ -80,21 +90,27 @@ fi
 # Get parameters
 PLUGINS=( "$@" )
 
+# Define constants
+TRANSLATIONS_OUTPUT_PATH="src/i18n-cache"
+
 echo -e "\n\033[1m== Updating i18n localizations ==\033[0m"
 
 # Validate parameters
 if [[ $((${#PLUGINS[@]}%2)) -ne 0 ]]; then
   error "Plugin arguments must be supplied as tuples (i.e. domain path/to/plugin)."
 fi
 
+# Check plugins parameters
 for (( index=0; index<${#PLUGINS[@]}; index+=2 )); do
   PLUGIN_FOLDER=${PLUGINS[index+1]}
 
-  if [[ ! -d $PLUGIN_FOLDER ]]; then
-    NOT_FOUND_PLUGIN_FOLDERS+=( $PLUGIN_FOLDER )
-    echo -e "\033[0;31mPlugin folder \"$PLUGIN_FOLDER\" doesn't exist.\033[0m"
-  fi
+  check_plugin "$PLUGIN_FOLDER"
 done
+
+# Check Gutenberg plugin
+check_plugin "./gutenberg"
+
+# Stop if can't find any plugin folder
 if [[ $(arrayLength "${NOT_FOUND_PLUGIN_FOLDERS[@]+"${NOT_FOUND_PLUGIN_FOLDERS[@]}"}") -gt 0 ]]; then
   exit 1
 fi
@@ -110,7 +126,6 @@ npm run build:gutenberg
 METRO_CONFIG="metro.config.js" node gutenberg/packages/react-native-editor/bin/extract-used-strings "$USED_STRINGS_PATH" "${PLUGINS[@]}"
 
 # Download translations of plugins (i.e. Jetpack)
-TRANSLATIONS_OUTPUT_PATH="src/i18n-cache"
 for (( index=0; index<${#PLUGINS[@]}; index+=2 )); do
   PLUGIN_NAME=${PLUGINS[index]}