iOS - Fix unwanted bottom inset when keyboard is open #448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #395
Child PR needs to be merged first. After that I'll tag that commit and update the dependency to point to the tag.
Parent PR is needed for testing with WPiOS.
Implementation details
The basic problem is solved with the first commit 09cb2f0 which updates the dependency to refer to our fork of the
react-native-keyboard-aware-scroll-viewlibrary.But still a small amount of extra padding was left on iPhone X variant devices, that was resulted from the safe area inset. So the rest of the commits solves only that small amount of extra padding. If you checkout 09cb2f0 and test on iPhone X you can view that extra padding.
To Test
yarn installDo below steps with iPhone 8, iPhone X(or variant), iPad
WPiOS
rake dependenciesAndroid
Open example app with Android
Verify it doesn't crash <- this is actually enough
Verify tapping to input text fields makes keyboard open properly by keeping text viewable.