Skip to content

Conversation

@wpmobilebot
Copy link
Collaborator

Related PRs

Description

This PR is generated by version-toolkit to downstream the changes for gutenberg submodule.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 14, 2022

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@jostnes jostnes requested a review from fluiddot March 15, 2022 04:34
@jostnes
Copy link
Contributor

jostnes commented Mar 15, 2022

👋 @fluiddot, the PR had an error on the Check Correctness step in the last commit and it suggested that I run npm install and commit the change which I did. The error is gone now, but I'm still unsure if that was the right thing to do (there is a change on package-lock.json file now, I made no change on package.json on this nor the Gutenberg PR). Can you help review this, please? Thanks!

@fluiddot
Copy link
Contributor

👋 @fluiddot, the PR had an error on the Check Correctness step in the last commit and it suggested that I run npm install and commit the change which I did. The error is gone now, but I'm still unsure if that was the right thing to do (there is a change on package-lock.json file now, I made no change on package.json on this nor the Gutenberg PR). Can you help review this, please? Thanks!

It can happen when updating the Gutenberg reference, that new commits coming from Gutenberg along with the ones that we want to push into GB-mobile require updating the package-lock.json file. It's not very common, but I've experienced it sometimes. In this case, I think it's expected, actually, I had to do the same on a different PR, so the changes look great to me.

@fluiddot fluiddot added this to the 1.72.0 milestone Mar 15, 2022
@fluiddot fluiddot added the Testing Anything related to automated tests label Mar 15, 2022
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @jostnes 🎊 !

Approved via WordPress/gutenberg#39377 (review).

@fluiddot
Copy link
Contributor

@jostnes let's wait for Test Android on Device - Full and Test iOS on Device - Full PR checks to finish and succeed before merging the PR. Once they finish, feel free to merge or if you don't have permission, let me know and I'll be more than happy to do it, thanks 🙇 .

@fluiddot
Copy link
Contributor

All PR checks, including the full tests suites, have passed in 4bea457 so the PR can be merged with auto-merge.

@fluiddot fluiddot enabled auto-merge March 15, 2022 10:13
@fluiddot fluiddot merged commit abfcb1c into trunk Mar 15, 2022
@fluiddot fluiddot deleted the version-toolkit/gutenberg/rnmobile/add-waitforvisible-android-flaky-tests branch March 15, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing Anything related to automated tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants