Re-introduce the react-native-aztec submodule to make JitPack green #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypest
added
[Status] Not Ready For Review
and removed
[Status] Not Ready For Review
labels
Contributor
Author
|
Oh no, 6840b35 was succeeding on JitPack but the follow up commit don't 🤦♂️. There might be an element of randomness here. |
hypest
force-pushed
the
try/move-submodule-before-subtree
branch
from
880c485 to
5d50a6f
Compare
JitPack has hard time checking out the git hash if we just go ahead and remove the submodule. Pity.
hypest
force-pushed
the
try/move-submodule-before-subtree
branch
from
b33f71f to
237f6ca
Compare
Contributor
Author
|
OK, I think it's all green at the moment, will lift the "not ready for review" label :). |
jtreanor
approved these changes
Jan 23, 2019
Contributor
jtreanor
left a comment
jtreanor
left a comment
There was a problem hiding this comment.
This is s pretty neat solution to an unpleasant situation.
Obviously we won't keep this hack for long but its good to get us unblocked now.
Contributor
|
LGTM! |
daniloercoli
approved these changes
Jan 23, 2019
etoledom
approved these changes
Jan 23, 2019
Contributor
etoledom
left a comment
etoledom
left a comment
There was a problem hiding this comment.
WPiOS is working fine with this branch.
I also don't see any change that could affect it 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-introduces the git submodule we removed recently,
but putting it in an obscure place.We need to do no work to update this submodule at all. Its code is not used anywhere and is only here because JitPack has trouble if it sees it go. For reference: jitpack/jitpack.io#3707.
We'll remove this submodule again, after the problem is fixed on the JitPack side of things.
To test:
Everything should work as normal, but this time
git submobule update --initwill pull in the "new" submodule. Let's do some testing with the demo app and the main WP apps against this one just to be sure. Thanks!For wpandroid, there's a PR up that be used for testing: wordpress-mobile/WordPress-Android#9052