Makes the media id used on uploads an Int. #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzorz
reviewed
Jan 23, 2019
| do { | ||
| try data.write(to: url) | ||
| mediaCallback(mediaID, url.absoluteString) | ||
| mediaCallback(mediaID.hashValue, url.absoluteString) |
Contributor
There was a problem hiding this comment.
Was reading this:
https://developer.apple.com/documentation/swift/hashable/1540917-hashvalue
Hash values are not guaranteed to be equal across different executions of your program. Do not save hash values to use during a future execution
Does it have any implications then, for example if you're uploading something and then close the app and open it again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.