Skip to content

Release 1.76.3 #4922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geriux merged 17 commits into from
Jun 3, 2022
Merged

Release 1.76.3 #4922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
46344ca
Release script: Update gb mobile version to 1.76.3
Jun 2, 2022
5f90209
Release script: Update gutenberg ref
Jun 2, 2022
8056ce8
Release script: Update bundle for: 1.76.3
Jun 2, 2022
eceefad
Update Gutenberg ref
Jun 2, 2022
220836c
Update third-party podspecs
Jun 2, 2022
7215972
Update FBReactNativeSpec podspec
Jun 2, 2022
e0fb09f
Update Gutenberg ref
Jun 2, 2022
2617856
Update release notes
Jun 2, 2022
b61a0d5
Update Gutenberg reference
Jun 2, 2022
18bb6ae
Update Release notes
Jun 2, 2022
81ab6f0
Update Gutenberg ref
Jun 2, 2022
9f1ff39
Merge with trunk
Jun 2, 2022
6059b9b
Update third-party podspecs
Jun 2, 2022
970e4e6
Update FBReactNativeSpec podspec
Jun 2, 2022
7162c60
Update bundles
Jun 2, 2022
45b9419
Revert jetpack ref update
Jun 2, 2022
52a1ef0
Update release notes
Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ Unreleased
* [*] [a11y] Improve text read by screen readers for BottomSheetSelectControl [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4854]
* [*] Add 'Insert from URL' option to Image block [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4779]

## 1.76.3
---
* [***] Fixes a crash on iOS related to JSI and Reanimated [https://github.com/WordPress/gutenberg/pull/41482]

## 1.76.2
---
* [*] Ensure post title gets focused when is notified from native side [https://github.com/WordPress/gutenberg/pull/41371]
Expand Down
2 changes: 0 additions & 2 deletions bundle/android/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,8 +346,6 @@ translators: %s: Select control option value e.g: "Auto, 25%". -->
<string name="gutenberg_native_ungroup" tools:ignore="UnusedResources">Ungroup</string>
<string name="gutenberg_native_unsupported" tools:ignore="UnusedResources">Unsupported</string>
<string name="gutenberg_native_updates_the_title" tools:ignore="UnusedResources">Updates the title.</string>
<string name="gutenberg_native_upgrade_your_plan_to_upload_audio" tools:ignore="UnusedResources">Upgrade your plan to upload audio</string>
<string name="gutenberg_native_upgrade_your_plan_to_use_video_covers" tools:ignore="UnusedResources">Upgrade your plan to use video covers</string>
Comment on lines -349 to -350
Copy link
Contributor

@fluiddot fluiddot Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geriux I'm curious why these strings were added in 1.77.0 and then removed in this PR 🤔 . As far as I checked, they come from Jetpack (reference) but I think they're not actually used in the editor.

Copy link
Contributor Author

@geriux geriux Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they show up again in 1.77.1 ?

Copy link
Contributor

@fluiddot fluiddot Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they show up again in 1.77.1 ?

Yep, after running the command npm run bundle, I see that these strings are re-introduced (reference).

I've checked this further and looks like the strings are expected to be here although they are not used. The file where they are defined (reference) it's being imported in a native file, hence as they're referenced, they're considered to be part of the editor and to be translated.

Copy link
Contributor

@fluiddot fluiddot Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, we haven't bumped into this change before because the Jetpack reference was recently updated, and a lot of time has passed since the last update.

Copy link
Contributor Author

@geriux geriux Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see I did encounter issues with the jetpack reference, I'm sure it's related. Sorry for that 😅

<string name="gutenberg_native_uploading" tools:ignore="UnusedResources">Uploading…</string>
<string name="gutenberg_native_use_icon_button" tools:ignore="UnusedResources">Use icon button</string>
<!-- translators: accessibility text. Empty video caption. -->
Expand Down
539 changes: 269 additions & 270 deletions bundle/ios/App.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/App.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 0 additions & 2 deletions bundle/ios/GutenbergNativeTranslations.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,6 @@ private func dummy() {
_ = NSLocalizedString("Ungroup", comment: "")
_ = NSLocalizedString("Unsupported", comment: "")
_ = NSLocalizedString("Updates the title.", comment: "")
_ = NSLocalizedString("Upgrade your plan to upload audio", comment: "")
_ = NSLocalizedString("Upgrade your plan to use video covers", comment: "")
_ = NSLocalizedString("Uploading…", comment: "")
_ = NSLocalizedString("Use icon button", comment: "")
_ = NSLocalizedString("Video caption. %s", comment: "translators: accessibility text. %s: video caption.")
Expand Down
2 changes: 1 addition & 1 deletion gutenberg
Open in desktop
Submodule gutenberg updated 20 files
+29 −2 docs/how-to-guides/block-tutorial/writing-your-first-block-type.md
+3 −3 package-lock.json
+9 −1 packages/components/CHANGELOG.md
+1 −1 packages/components/src/date-time/date/index.tsx
+0 −725 packages/components/src/form-token-field/index.js
+707 −0 packages/components/src/form-token-field/index.tsx
+0 −102 packages/components/src/form-token-field/stories/index.js
+104 −0 packages/components/src/form-token-field/stories/index.tsx
+45 −29 packages/components/src/form-token-field/suggestions-list.tsx
+64 −31 packages/components/src/form-token-field/test/index.js
+24 −9 packages/components/src/form-token-field/test/lib/token-field-wrapper.tsx
+0 −81 packages/components/src/form-token-field/token-input.js
+76 −0 packages/components/src/form-token-field/token-input.tsx
+2 −1 packages/components/src/form-token-field/token.tsx
+178 −0 packages/components/src/form-token-field/types.ts
+2 −0 packages/components/tsconfig.json
+4 −0 packages/react-native-editor/CHANGELOG.md
+2 −2 packages/react-native-editor/ios/Podfile.lock
+1 −1 packages/react-native-editor/package.json
+18 −0 typings/dom-scroll-into-view/index.d.ts
2 changes: 1 addition & 1 deletion third-party-podspecs/FBReactNativeSpec/FBReactNativeSpec.podspec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"compiler_flags": "-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -Wno-comma -Wno-shorten-64-to-32 -Wno-nullability-completeness",
"source": {
"git": "https://github.com/wordpress-mobile/gutenberg-mobile.git",
"commit": "593a3712249f2d0dbbe71f5dacf5216a5e34ed27",
"commit": "6059b9b51b10669b867690993b9e18c4b0a8f2a3",
"submodules": "true"
},
"source_files": "third-party-podspecs/FBReactNativeSpec/**/*.{c,h,m,mm,cpp}",
Expand Down
4 changes: 2 additions & 2 deletions third-party-podspecs/RNReanimated.podspec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "RNReanimated",
"version": "2.4.1-wp-2",
"version": "2.4.1-wp-3",
"summary": "More powerful alternative to Animated library for React Native.",
"description": "RNReanimated",
"homepage": "https://github.com/software-mansion/react-native-reanimated",
Expand All @@ -14,7 +14,7 @@
},
"source": {
"git": "https://github.com/wordpress-mobile/react-native-reanimated.git",
"tag": "2.4.1-wp-2"
"tag": "2.4.1-wp-3"
},
"source_files": [
"ios/**/*.{mm,h,m}",
Expand Down