Media upload progress reattach android #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d progress when re-entering the editor
…updates right when componentDidMount
1 task
| return RNReactNativeGutenbergBridge.onCapturePhotoPressed( callback ); | ||
| } | ||
|
|
||
| export function onImageQueryReattach( callback ) { |
Contributor
There was a problem hiding this comment.
Shouldn't we send up what is the ID of the media we want to reattach?
Contributor
Author
There was a problem hiding this comment.
It's not necessary to be passed here at all, as all we need to do is to tell the parent app which the new callback is so it can be set in this line here.
Later the events are being broadcasted and there we tell the listeners which progress is being made for which mediaId.
2 tasks
marecar3
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the needed interfaces to make Gutenberg start receiving upload progress updates when it's shown on the screen, for images that exist within the open Post that are currently being uploaded.
This can be tested with the WPAndroid PR wordpress-mobile/WordPress-Android#9129
Related Gutenberg PR:
WordPress/gutenberg#13516
Notes:
MediaUploadCallbackimplementation a bit as it's needed to be passed to 3 interfaces (onCapturePhotoPressed,onUploadMediaPressed, and now alsoonImageQueryReattach)componentDidUpdate()in Introduce onImageQueryReattach interface WordPress/gutenberg#13516 instead of waiting for the next update (this is useful for slow connections where there would be a gap between the time the user opens the Editor and an update is actually seen)