passing mediaId in onMediaSelected #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
marecar3
approved these changes
Jan 30, 2019
Contributor
marecar3
left a comment
marecar3
left a comment
There was a problem hiding this comment.
LGTM!
Maybe we need also iOS support here @mzorz @SergioEstevao?
# Conflicts: # react-native-gutenberg-bridge/android/src/main/java/org/wordpress/mobile/ReactNativeGutenbergBridge/RNReactNativeGutenbergBridgeModule.java
daniloercoli
added a commit
that referenced
this pull request
Jan 30, 2019
…rg-mobile into issue/372-move-title-to-rich-text * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: Added missing react method signature (#523) passing mediaId in onMediaSelected (#521) v0.3.4 Update GB bundle. Refactor name of MediaSource to avoid name collision on the main app. Update Gutenberg reference. refactor media upload methods to be inline with JS and iOS Refactor names of helper methods. Change media upload sync method. Implement enum using strings to simplify conversion logic. Remove whitespace Refactor method name to make it more obvious the intent. Refactor bridge media protocol methods to a single method. Merge branch 'develop' into feature/media_upload_methods_refactor Refactor media upload names to more consistent names. Removes border from title and changes the placeholder text. passing null to onImageQueryReattach() on Android Implement reattach of events on iOS. Add the ability to set font family, weight, size, and style from RN Recommend using the gutenberg-mobile repo # Conflicts: # gutenberg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #520
WPAndroid PR here:
wordpress-mobile/WordPress-Android#9151