Add onImageFailedRetry interface #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated gutenberg mobile submodule
Contributor
Author
|
This one is ready for iOS to be added @SergioEstevao |
Contributor
Author
|
@SergioEstevao added a way to clear an image block and unset it in WordPress/gutenberg#13610, referenced in this PR in commit 6f9b05f |
1 task
# Conflicts: # gutenberg
…/gutenberg-mobile into add/retry-failed-upload
…/gutenberg-mobile into add/retry-failed-upload
marecar3
approved these changes
Jan 31, 2019
Contributor
marecar3
left a comment
marecar3
left a comment
There was a problem hiding this comment.
LGTM regarding Android/Java code.
…/gutenberg-mobile into add/retry-failed-upload
… conversion issues to JS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the failed / retry interface in the bridge (Android side).
We need the iOS side as well. @SergioEstevao