Skip to content

Release 1.90.0 #5523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcalhoun merged 6 commits into from
Mar 2, 2023
Merged

Release 1.90.0 #5523

dcalhoun merged 6 commits into from
Mar 2, 2023

Conversation

@dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Mar 2, 2023 •
edited
Loading

Release for Gutenberg Mobile 1.90.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Change 1

Change 2

Change 3

Change 4

Change 5

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

This was referenced Mar 2, 2023
Merged
Merged
Merged
@dcalhoun dcalhoun marked this pull request as ready for review March 2, 2023 16:20
@SiobhyB SiobhyB self-requested a review March 2, 2023 16:46
SiobhyB
SiobhyB approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#48694 (review)

@dcalhoun dcalhoun enabled auto-merge March 2, 2023 20:00
@dcalhoun dcalhoun merged commit b47c82a into trunk Mar 2, 2023
@dcalhoun dcalhoun deleted the release/1.90.0 branch March 2, 2023 20:37
@dcalhoun
Copy link
Member Author

dcalhoun commented Mar 7, 2023 •
edited
Loading

🟢 Included Changes (iOS)

Build: 21.9.0.0 (TestFlight)
Device: iPhone SE (iOS 16.4.0)

@dcalhoun
Copy link
Member Author

dcalhoun commented Mar 7, 2023 •
edited
Loading

🟢 Writing Flow checklist (iOS)

Build: 21.9.0.0 (TestFlight)
Device: iPhone SE (iOS 16.4.0)

General

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@dcalhoun
Copy link
Member Author

dcalhoun commented Mar 7, 2023 •
edited
Loading

🟢 Unsupported Block Tests (iOS)

Build: 21.9.0.0 (TestFlight)
Device: iPhone SE (iOS 16.4.0)

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
    ⚠️ Encountered "The editor has encountered an unexpected error.", but it also occurs while using a mobile web browser outside of the app. Likely related to Editor crashes on page load in Safari (trunk & 6.2 beta 1) WordPress/gutenberg#47865, as I am currently running iOS 16.4 beta on my device.
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@dcalhoun
Copy link
Member Author

dcalhoun commented Mar 7, 2023 •
edited
Loading

🔴 Sanity Test Suite 1 (iOS)

Build: 21.9.0.0 (TestFlight)
Device: iPhone SE (iOS 16.4.0)

Gallery - 1

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC04
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Columns - 1

  • Columns - Multiple slider in columns parent - TC011
  • Columns - Check if Column placeholders is visible for the unselected state - TC001
  • Columns - Appearance in vertical device position (vertical layout) - TC004

Columns - 2

  • Columns - Max limit of Column number - TC002
  • Columns - Deep nesting is possible (iOS only)- TC003
  • Columns - Appearance in horizontal device position (horizontal layout) - TC005

Columns - 3

MediaText - 1

MediaText - 2

  • Media Text block - Insert video from device (TC002) - steps
  • Media Text block - Insert image from device (TC002) - steps

MultipleUpload - 1

  • Simultaneous uploads - TC001

Cover - 1

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Image focal point is rendered properly - TC002
  • Cover - Custom color is rendered properly - TC002

Editor Theme - 1

  • Default Colors - Check that default colors still load - TC001
  • Default Gradients - Check that default gradients still load - TC002
  • Custom Colors - Check that custom colors load in the editor - TC003

Social Icons - 1

  • Active icon gets product color - TC001
  • Social icon forwarding to the link - TC002

@jhnstn
Copy link
Member

jhnstn commented Mar 7, 2023 •
edited
Loading

🟢 Sanity Test Suite 5 (Android)

Build 21.9-rc-1
Device Pixel 6 (Android 13)

Video block - 1

  • Video block - Insert video from device (failing) - TC001
  • Video block - Close/Re-open post with an ongoing video upload - TC004

Video block - 2

  • Video block - Insert video from device (cancel) - TC002
  • Video block - Close post with an ongoing video upload - TC005
  • Video block - Add Caption - TC003

File block - 1

  • File block - Upload completes successfully from the device library - TC001
  • File block - Insert completes successfully from the WordPress Media library - TC002
  • File block - Upload fails from the device library - TC003
  • File block - Stop the file upload before it completes - TC004

File block - 2

  • File block - Close the post with an ongoing file upload - TC005

    • ⚠️ Test case is invalid - notification pops up that saving is not allowed while a file is being uploaded.

  • File block - Replace the selected files - TC006

  • File block - Change the alignment in the File Block - TC007

  • File block - The Link To Block Setting should open - TC008

File block - 3

  • File block - Open link in new tab - TC009
  • File block - Show/hide download button (Block Settings only) - TC010
  • File block - Copy file URL - TC011
  • File block - Close/Re-open post with an ongoing file upload - TC012

Audio block - 1

  • Audio block - Upload completes successfully from the device library - TC001
  • Audio block - Insert completes successfully from the WordPress Media library - TC002

Audio block - 2

  • Audio block - Upload fails from the device library - TC003
  • Audio block - Stop the audio file upload before it completes - TC004

Audio block - 3

  • Audio block - Close the post with an ongoing audio file upload - TC005
  • Audio block - Replace the selected files - TC006
  • Audio block - Change the alignment in the Audio Block - TC007

Audio block - 4

  • Audio block - Autoplay setting - TC008
  • Audio block - Loop setting - TC009
  • Audio block - Close/Re-open post with an ongoing audio file upload - TC010

Reusable block - 1

  • Reusable block - Add block - TC001
  • Reusable block - Convert to regular blocks - TC002

Reusable block - 2

  • Reusable block - Deleted reusable block - TC003
  • Reusable block - Recursive block rendering - TC004

Embed block - 1

  • Embed block - Inline previews are rendered correctly for the top 5 most-used providers - TC001

Embed block - 2

  • Embed block - Inline previews are rendered accordingly for each alignment option - TC002

@jhnstn
Copy link
Member

jhnstn commented Mar 8, 2023 •
edited
Loading

🟢 Writing Flow checklist (Android)

Build 21.9-rc-1
Device Pixel 6 (Android 13)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
    • ⚠️ Encountered known issue: Deleting "swiped" or selected words prevents merging
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
    • ⚠️ Encountered known issue: Deleting "swiped" or selected words prevents merging
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
    • ⚠️ Encountered known issue: Deleting "swiped" or selected words prevents merging
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@jhnstn
Copy link
Member

jhnstn commented Mar 8, 2023 •
edited
Loading

🟢 Unsupported Block Tests (Android)

Build [21.9-rc-1](https://github.com/wordpress-mobile/WordPress-Android/releases/tag/untagged-9f6e577aa72a5d90b2e2)
Device Pixel 6 (Android 13)

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@jhnstn
Copy link
Member

jhnstn commented Mar 8, 2023 •
edited
Loading

🟢 Included Changes (Android)

Build 21.9-rc-1
Device Pixel 6 (Android 13)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SiobhyB SiobhyB SiobhyB approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dcalhoun @jhnstn @SiobhyB