Skip to content

Conversation

@dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Aug 28, 2023

The active icon color communicates the link has a valid URL set.

Related PRs

Testing Instructions

n/a

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

The active icon color communicates the link has a valid URL set.
@dcalhoun dcalhoun self-assigned this Aug 28, 2023
@dcalhoun dcalhoun added the Testing Anything related to automated tests label Aug 28, 2023
@dcalhoun dcalhoun marked this pull request as ready for review August 28, 2023 21:36
@dcalhoun dcalhoun requested a review from derekblank August 28, 2023 21:36
Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀

@derekblank
Copy link
Contributor

derekblank commented Aug 29, 2023

@dcalhoun I'm not sure if it's worth adding an extra step to the visual test to add a new Social Link block via the [+] button to open the Social Link button inserter and test the block outline with another snapshot, as referenced by the fix in WordPress/gutenberg#54011.

If that PR looks good, and you feel like this visual test should take a second snapshot with this updated UI behavior of adding a new Social Link block, feel free to merge that PR and update the test. Otherwise, I can add the extra step to this visual test in a subsequent PR once #54011 is merged, or we can de-prioritize actually needing to test this extra step with a visual test (which is what I am leaning toward). Either way, I just wanted to note it.

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

1 similar comment
@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dcalhoun
Copy link
Member Author

I'm not sure if it's worth adding an extra step to the visual test to add a new Social Link block via the [+] button to open the Social Link button inserter and test the block outline with another snapshot, as referenced by the fix in WordPress/gutenberg#54011.

Good thought. We can follow up on this subject as needed in a separate PR once it is merged.

@dcalhoun dcalhoun enabled auto-merge August 29, 2023 12:15
dcalhoun added a commit to wordpress-mobile/test-cases that referenced this pull request Aug 29, 2023
@dcalhoun dcalhoun merged commit fbce61c into trunk Aug 29, 2023
@dcalhoun dcalhoun deleted the test/social-icons branch August 29, 2023 12:59
@geriux geriux added this to the 1.103.0 (23.2) milestone Aug 31, 2023
derekblank pushed a commit to wordpress-mobile/test-cases that referenced this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing Anything related to automated tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants