-
Notifications
You must be signed in to change notification settings - Fork 57
test: Social Links should display active icon color #6118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The active icon color communicates the link has a valid URL set.
derekblank
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 🚀
|
@dcalhoun I'm not sure if it's worth adding an extra step to the visual test to add a new Social Link block via the [+] button to open the Social Link button inserter and test the block outline with another snapshot, as referenced by the fix in WordPress/gutenberg#54011. If that PR looks good, and you feel like this visual test should take a second snapshot with this updated UI behavior of adding a new Social Link block, feel free to merge that PR and update the test. Otherwise, I can add the extra step to this visual test in a subsequent PR once #54011 is merged, or we can de-prioritize actually needing to test this extra step with a visual test (which is what I am leaning toward). Either way, I just wanted to note it. |
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
1 similar comment
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
Good thought. We can follow up on this subject as needed in a separate PR once it is merged. |
These tests were automated in the following: - WordPress/gutenberg#53991 - wordpress-mobile/gutenberg-mobile#6118
These tests were automated in the following: - WordPress/gutenberg#53991 - wordpress-mobile/gutenberg-mobile#6118
The active icon color communicates the link has a valid URL set.
Related PRs
Testing Instructions
n/a
PR submission checklist: