Skip to content

Conversation

@fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jan 4, 2024

Fixes an issue in the CI job lint that we've recently encountered in PRs (325366d).

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory

To test:

  • Check that all CI jobs pass.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

# Reference: https://git.io/J9q2S
- 'WP_CLI_ALLOW_ROOT=true'
# Increase max available memory for node
- 'NODE_OPTIONS="--max-old-space-size=4096"'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we could set this option directly in the Docker image.

@fluiddot fluiddot marked this pull request as ready for review January 4, 2024 17:15
@geriux geriux self-requested a review January 4, 2024 17:17
@geriux
Copy link
Contributor

geriux commented Jan 4, 2024

The XCFramework is failing because the Podfile.lock is missing an update from the release, which is included in this PR. Should we cherry-pick this PR into the Release PR? Or update the Podfile.lock here?

@fluiddot
Copy link
Contributor Author

fluiddot commented Jan 4, 2024

The XCFramework is failing because the Podfile.lock is missing an update from the release, which is included in #6500. Should we cherry-pick this PR into the Release PR? Or update the Podfile.lock here?

Ah, true, I forgot to update the Podfile.lock. I'll update it, thanks 🙇 !

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All CI checks passed ✅

@fluiddot fluiddot merged commit a1ba444 into trunk Jan 4, 2024
@fluiddot fluiddot deleted the update/ci-increase-node-max-available-memory branch January 4, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants