[iOS]Update heading placeholder size on heading level change #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinarol
added
[Type] Bug
1 task
daniloercoli
added a commit
that referenced
this pull request
Mar 14, 2019
…rg-mobile into issue/707-Placeholder-is-missing-on-Heading-block * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: (22 commits) Update gutenberg ref Update gutenberg ref Update gutenberg ref Update heading placeholder size on heading level change (#742) Fix - HTML Editor - Keyboard can not be closed (#743) Update gutenberg ref Update gutenberg ref Fix lint errors Make sure onSafeAreaInsetsUpdate isn't called when BlockManager is unmounted Remove extra semicolon Remove unused editor settings prop Unmount the app after each test to prevent dangling subscribers Fix switching to html when initialHtmlModeEnabled is true Auto import native versions of variables and colors Fix lint errors Use @wordpress/edit-post package to bootstrap the editor and refactor components Add symlink for @wordpress/token-list Minor syntax fixes Update tests to use the un deprecated version of the store methods Update gutenberg ref ... # Conflicts: # gutenberg
daniloercoli
added a commit
that referenced
this pull request
Mar 15, 2019
…rg-mobile into issue/345-fix-for-press-delete-no-merge-move-focus * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: (39 commits) Update gb hash after merging the companion PR Update GB ref Update gutenberg ref Update gutenberg ref Update gutenberg ref Tests: Add mock for the newly added CSS class Update GB ref Raise the minHeight value for heading block to 60 (it was 50) Introduce a constant for the string `tag` and use it instead of the hard coded string Make `tagName` private Update heading placeholder size on heading level change (#742) Fix - HTML Editor - Keyboard can not be closed (#743) Update gutenberg ref Update gutenberg ref Update GB ref Add comments Update caret position after inserting link (#716) Update GB hash Reuse `blockType` instead of adding a new property Update GB ref ... # Conflicts: # src/block-management/block-holder.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #671
WPiOS PR: wordpress-mobile/WordPress-iOS#11258
This PR fixes the issue about heading placeholder not adjusting itself due to heading level.
After the fix:
To Test
Checkout branch on WPiOS PR: wordpress-mobile/WordPress-iOS#11258