Preserve existing attributes in setAttributes #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings the implementation closer to the web by only changing the
specified attributes instead of replacing everything with the passed
attributes.
This means that callers don't need to be aware and prepend
`...this.props.attributes` and can just worry about specifying the
change they want (e.g. `setAttributes( { dropCap: ! attributes.dropCap } );`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the implementation closer to the web by only changing the specified attributes instead of replacing everything with the passed attributes.
This means that callers don't need to be aware and prepend
...this.props.attributesand can just worry about specifying the change they want, for instance:This was added so that our
onChangeandonContentSizeChangemethods don't need to have access tothis.props, but also to match how the web behaves.