Fix crash on undefined image url #976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix crash on undefined image url
Generated by 🚫 dangerJS |
Contributor
Author
|
I fixed the hotfix version number and merged the previous PR into this one as per this comment: #967 (comment). |
Contributor
|
Headsup, let's hold off merging this one since there is a PR that got merged to the main apps that brings in the latest of gutenberg-mobile develop (which is currently broken though). Also, please open a WPAndroid PR as well so we can track this better, thanks! |
1 task
Contributor
Author
|
I have opened the PR on WPAndroid to update the submodule reference there to this one. The issues blocking the develop branch should be non-blocking here, as this PR targets master as a hotfix (assuming we go forward with that). |
daniloercoli
approved these changes
May 13, 2019
Contributor
daniloercoli
left a comment
daniloercoli
left a comment
There was a problem hiding this comment.
Changes looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Gutenberg reference to bring in the changes in this companion PR: WordPress/gutenberg#15532.
This PR adds a check to ensure
attributes.urlexists before attempting to callindexof. Currently, there are scenarios which can result inattributes.idbeing truthy, whileattributes.urlis null or undefined for an image block.When an image is cancelled before it is finished uploading, the
urlis set tonull, but theidof the block remains. The next time the post is edited, the local draft will contain the state which triggers the crash.Testing steps:
This was tested using the steps here: wordpress-mobile/WordPress-Android#9768 (comment)
Types of changes
This is a bug fix for the crash discovered here: wordpress-mobile/WordPress-Android#9768