This repository was archived by the owner on Mar 7, 2025. It is now read-only.
Follow Up from links handling PR #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koke
reviewed
Dec 12, 2018
ios/RNTAztecView/RCTAztecView.swift
Outdated
| identifiers = formattingIdentifiersForTypingAttributes() | ||
| } | ||
| let formats = identifiers.compactMap(formatString) | ||
| let formats = identifiers.compactMap { self.formatStringMap[$0] } |
Member
There was a problem hiding this comment.
My swift might be rusty but I don’t think you need the self. inside a non-escaping closure?
Contributor
Author
There was a problem hiding this comment.
You are right!
Your swift is better than mine 😅
diegoreymendez
approved these changes
Dec 13, 2018
Contributor
diegoreymendez
left a comment
diegoreymendez
left a comment
There was a problem hiding this comment.
Tested and working fine!
Contributor
Author
|
Thank you @diegoreymendez ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the comments from #87, since it was merged before I could get to make the requested modifications. (Sorry about the delay)
To test:
strikethroughare working properly.