This repository was archived by the owner on Jul 27, 2023. It is now read-only.
Disable upgrade notice warning on Jest environment #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
approved these changes
Mar 1, 2022
geriux
left a comment
geriux
left a comment
There was a problem hiding this comment.
LGTM! I confirmed that the changes align with the upstream changes:
- https://github.com/software-mansion/react-native-gesture-handler/blob/main/src/utils.ts#L34
- https://github.com/software-mansion/react-native-gesture-handler/blob/44ee0c05234930b65e3a539be201841be56846a9/src/handlers/createHandler.ts#L178-L180
Thanks for fixing this issue! 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting off version
2.2.0, the following warning message is shown when the old API of the library is used:While this is expected when running the app, it's not when running unit tests. In fact, it might lead to errors if the tests fail due to unexpected console logs like we're experiencing in this Gutenberg PR.
I noticed that this issue is already addressed in the original repository (reference), however, it hasn't been released yet.