Skip to content

feat: allow dynamic redirect on success #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
axlEscalada wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: allow dynamic redirect on success #321

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea799dc
feat: allow dynamic redirect on success
axlEscalada Oct 14, 2025
73cc82a
feat: use a better name for on success response since we allow NextRe…
axlEscalada Oct 14, 2025
1500614
feat: run prettier
axlEscalada Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: use a better name for on success response since we allow NextRe… 
…sponse and not just redirects
  • Loading branch information
@axlEscalada
axlEscalada committed Oct 14, 2025
commit 73cc82ac574d644af6580136495f9bf958a73616
6 changes: 3 additions & 3 deletions src/authkit-callback-route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export function handleAuth(options: HandleAuthOptions = {}) {
await saveSession({ accessToken, refreshToken, user, impersonator }, request);

if (onSuccess) {
const redirect = await onSuccess({
const onSuccessResponse = await onSuccess({
Copy link
Copy Markdown
Member

@nicknisi nicknisi Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: I wonder if it makes sense to provide the default response as an argument to onSuccess? That way, you don't always need to create a new one from scratch.

This would also help make it more explicit that if onSuccess returns a NextResponse, it's going to take precedence over returnPathname if both are provided.

accessToken,
refreshToken,
user,
Expand All @@ -107,8 +107,8 @@ export function handleAuth(options: HandleAuthOptions = {}) {
state: customState,
});

if (redirect) {
return redirect;
if (onSuccessResponse) {
return onSuccessResponse;
}
}

Expand Down
Loading