fix: fixed and refactored signAndSendTransaction on solana by bradleyplaydon · Pull Request #3812 · wormhole-foundation/wormhole-connect

bradleyplaydon · 2025-09-23T18:09:03Z

Refactored retry and resend logic on solana signAndSendTransaction
- Changed promise race delay from 5 seconds -> 1 second, this means we resend every second if confirmation promise doesn't resolve.
- Remove custom retry loop for retry from es-toolkit and added function recoverBlockheightExceededTransaction

netlify · 2025-09-23T18:09:09Z

✅ Deploy Preview for wormhole-connect ready!

Name	Link
🔨 Latest commit	`9512597`
🔍 Latest deploy log	https://app.netlify.com/projects/wormhole-connect/deploys/68d585b6256e0d0008fdf82b
😎 Deploy Preview	https://deploy-preview-3812--wormhole-connect.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-09-23T18:09:09Z

✅ Deploy Preview for wormhole-connect-mainnet ready!

Name	Link
🔨 Latest commit	`9512597`
🔍 Latest deploy log	https://app.netlify.com/projects/wormhole-connect-mainnet/deploys/68d585b6e6889700080f880c
😎 Deploy Preview	https://deploy-preview-3812--wormhole-connect-mainnet.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

src/utils/wallet/solana.ts

…actionWithRetry

…actionWhilstResending

src/utils/wallet/solana.ts

src/utils/index.ts

src/utils/wallet/solana.ts

src/utils/inProgressTxCache.ts

src/utils/wallet/solana.ts

bradleyplaydon temporarily deployed to ci September 23, 2025 18:09 — with GitHub Actions Inactive

bradleyplaydon temporarily deployed to ci September 23, 2025 18:29 — with GitHub Actions Inactive

bradleyplaydon commented Sep 23, 2025

View reviewed changes

src/utils/wallet/solana.ts Outdated Show resolved Hide resolved

bradleyplaydon commented Sep 23, 2025

View reviewed changes

src/utils/wallet/solana.ts Outdated Show resolved Hide resolved

bradleyplaydon force-pushed the feat/improve-solana-performance branch from e88b400 to 3797833 Compare September 23, 2025 18:33

bradleyplaydon temporarily deployed to ci September 23, 2025 18:33 — with GitHub Actions Inactive

bradleyplaydon temporarily deployed to ci September 23, 2025 18:42 — with GitHub Actions Inactive

bradleyplaydon temporarily deployed to ci September 23, 2025 18:50 — with GitHub Actions Inactive

bradleyplaydon marked this pull request as ready for review September 23, 2025 19:19

priyajeet requested a review from kev1n-peters September 23, 2025 21:03

kev1n-peters reviewed Sep 23, 2025

View reviewed changes

src/utils/wallet/solana.ts Show resolved Hide resolved

priyajeet reviewed Sep 23, 2025

View reviewed changes

src/utils/wallet/solana.ts Outdated Show resolved Hide resolved

priyajeet reviewed Sep 23, 2025

View reviewed changes

src/utils/wallet/solana.ts Outdated Show resolved Hide resolved

bradleyplaydon temporarily deployed to ci September 23, 2025 22:43 — with GitHub Actions Inactive

priyajeet reviewed Sep 23, 2025

View reviewed changes

src/utils/wallet/solana.ts Outdated Show resolved Hide resolved

src/utils/wallet/solana.ts Outdated Show resolved Hide resolved

src/utils/wallet/solana.ts Outdated Show resolved Hide resolved

priyajeet reviewed Sep 23, 2025

View reviewed changes

src/utils/wallet/solana.ts Outdated Show resolved Hide resolved

priyajeet reviewed Sep 23, 2025

View reviewed changes

src/utils/wallet/solana.ts Outdated Show resolved Hide resolved

priyajeet reviewed Sep 23, 2025

View reviewed changes

src/utils/wallet/solana.ts Outdated Show resolved Hide resolved

priyajeet reviewed Sep 23, 2025

View reviewed changes

src/utils/wallet/solana.ts Outdated Show resolved Hide resolved

priyajeet reviewed Sep 23, 2025

View reviewed changes

src/utils/wallet/solana.ts Outdated Show resolved Hide resolved

priyajeet reviewed Sep 23, 2025

View reviewed changes

src/utils/wallet/solana.ts Outdated Show resolved Hide resolved

priyajeet reviewed Sep 23, 2025

View reviewed changes

src/utils/wallet/solana.ts Outdated Show resolved Hide resolved

priyajeet reviewed Sep 23, 2025

View reviewed changes

src/utils/wallet/solana.ts Outdated Show resolved Hide resolved

kev1n-peters reviewed Sep 24, 2025

View reviewed changes

src/utils/wallet/solana.ts Outdated Show resolved Hide resolved

bradleyplaydon temporarily deployed to ci September 24, 2025 19:51 — with GitHub Actions Inactive

bradleyplaydon added 3 commits September 24, 2025 21:19

fix: fixed and refactored signAndSendTransaction on solana

5efe999

fix: fix build

66cceff

refactor: clear up comments, change function names

8c7895d

bradleyplaydon added 3 commits September 24, 2025 21:19

refactor: add resend tx indefinitly until success, await confirmTrans…

b29d119

…actionWithRetry

refactor: refactored signAndConfirmTransaction to signAndConfirmTrans…

b298950

…actionWhilstResending

refactor: add formatConfirmationError

895040c

bradleyplaydon force-pushed the feat/improve-solana-performance branch from bee22b4 to 895040c Compare September 24, 2025 20:20

bradleyplaydon temporarily deployed to ci September 24, 2025 20:20 — with GitHub Actions Inactive

chore: bump confirmationPromiseTimer

4c02919

bradleyplaydon temporarily deployed to ci September 24, 2025 20:41 — with GitHub Actions Inactive

priyajeet reviewed Sep 25, 2025

View reviewed changes

fix: address PR comments

0326af0

bradleyplaydon temporarily deployed to ci September 25, 2025 15:29 — with GitHub Actions Inactive

priyajeet reviewed Sep 25, 2025

View reviewed changes

src/utils/index.ts Outdated Show resolved Hide resolved

priyajeet reviewed Sep 25, 2025

View reviewed changes

src/utils/wallet/solana.ts Show resolved Hide resolved

priyajeet reviewed Sep 25, 2025

View reviewed changes

src/utils/wallet/solana.ts Outdated Show resolved Hide resolved

refactor: change JSONReplacer to stringifyWithBigInt

9f5027a

bradleyplaydon temporarily deployed to ci September 25, 2025 16:48 — with GitHub Actions Inactive

bradleyplaydon temporarily deployed to ci September 25, 2025 16:51 — with GitHub Actions Inactive

bradleyplaydon force-pushed the feat/improve-solana-performance branch from 717bede to 9f5027a Compare September 25, 2025 17:12

bradleyplaydon temporarily deployed to ci September 25, 2025 17:13 — with GitHub Actions Inactive

priyajeet reviewed Sep 25, 2025

View reviewed changes

src/utils/wallet/solana.ts Show resolved Hide resolved

refactor: add throw back to catch

3b9b0ba

bradleyplaydon temporarily deployed to ci September 25, 2025 17:27 — with GitHub Actions Inactive

fix: remove unnecessary nested try catch

9512597

bradleyplaydon temporarily deployed to ci September 25, 2025 18:11 — with GitHub Actions Inactive

priyajeet approved these changes Sep 26, 2025

View reviewed changes

kev1n-peters reviewed Sep 26, 2025

View reviewed changes

src/utils/inProgressTxCache.ts Show resolved Hide resolved

kev1n-peters reviewed Sep 26, 2025

View reviewed changes

src/utils/wallet/solana.ts Show resolved Hide resolved

bradleyplaydon merged commit e32a965 into development Sep 29, 2025
20 checks passed

bradleyplaydon deleted the feat/improve-solana-performance branch September 29, 2025 16:18

Conversation

bradleyplaydon commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for wormhole-connect ready!

Uh oh!

netlify bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for wormhole-connect-mainnet ready!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bradleyplaydon commented Sep 23, 2025 •

edited

Loading

netlify bot commented Sep 23, 2025 •

edited

Loading

netlify bot commented Sep 23, 2025 •

edited

Loading