Skip to content

feat: do not eagerly fetch prices for tokens with no balance #3874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kev1n-peters merged 1 commit into from
Oct 15, 2025
Merged

feat: do not eagerly fetch prices for tokens with no balance #3874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/utils/tokenListUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
import { calculateUSDPriceRaw, isFrankensteinToken } from 'utils';
import config from 'config';
import { isNttToken } from './ntt';
import type { Balances } from './wallet/types';

export const getTokenPreferenceScore = (
token: Token,
Expand Down Expand Up @@ -42,11 +43,11 @@ export const getTokenPreferenceScore = (

export const calculateTokenUSDBalance = (
token: Token,
balances: Record<string, { balance: any }>,
balances: Balances,
getTokenPrice: (token: Token) => number | undefined,
): number => {
const balance = balances[tokenKey(token)];
if (!balance || !balance.balance) {
if (!balance || !balance.balance || balance.balance.amount === '0') {
return 0;
}
return calculateUSDPriceRaw(getTokenPrice, balance.balance, token) ?? 0;
Expand Down Expand Up @@ -87,7 +88,7 @@ export const applyTokenSearch = (
export const sortTokensByPreference = (
tokens: Token[],
selectedToken: Token | undefined,
balances: Record<string, { balance: any }>,
balances: Balances,
getTokenPrice: (token: Token) => number | undefined,
): Token[] => {
return tokens.sort((a, b) => {
Expand Down
Loading