Skip to content

Extract pattern metadata (title & description) #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 10 commits into from
Apr 6, 2022
Merged

Extract pattern metadata (title & description) #312

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7f7bc16
Add support for translating the Title from patterns in /patterns
oandregal Apr 5, 2022
cc4b02b
Extract description as well
oandregal Apr 5, 2022
4cff589
Fix lint issues
oandregal Apr 5, 2022
2b14dfd
Add context & file name as comment
oandregal Apr 5, 2022
ffa8702
Update context for title & description
oandregal Apr 5, 2022
3298a2a
Fix lint issue
oandregal Apr 5, 2022
29c3b19
Update comment
oandregal Apr 5, 2022
fe3b26d
Add behat test
oandregal Apr 6, 2022
8b584de
Remove tag used in testing
oandregal Apr 6, 2022
4a4549b
Update src/MakePotCommand.php
oandregal Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add context & file name as comment
  • Loading branch information
@oandregal
oandregal committed Apr 5, 2022
commit 2b14dfd9c310cba6708eafb6aa2c2796289ec234
8 changes: 4 additions & 4 deletions src/IterableCodeExtractor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,15 @@ public static function fromFile( $file_or_files, Translations $translations, arr
);

if ( ! empty( $headers['Title'] ) ) {
$translation = new Translation( '', $headers['Title'] );
$translation->addExtractedComment( 'Title of the pattern' );
$translation = new Translation( 'Title of the pattern', $headers['Title'] );
$translation->addReference( $options[ 'file' ] );

$translations[] = $translation;
}

if ( ! empty( $headers['Description'] ) ) {
$translation = new Translation( '', $headers['Description'] );
$translation->addExtractedComment( 'Description of the pattern' );
$translation = new Translation( 'Description of the pattern', $headers['Description'] );
$translation->addReference( $options[ 'file' ] );

$translations[] = $translation;
}
Expand Down