Skip to content

Update airframe-http, airframe-http-netty, ... to 2025.1.23 - #4130

Merged
xerial merged 1 commit into
mainfrom
update/airframe-http-2025.1.23
Jan 6, 2026
Merged

Update airframe-http, airframe-http-netty, ... to 2025.1.23#4130
xerial merged 1 commit into
mainfrom
update/airframe-http-2025.1.23

Conversation

@xerial-bot

Copy link
Copy Markdown
Collaborator

About this PR

📦 Updates

from 2025.1.22 to 2025.1.23

📜 GitHub Release Notes - Version Diff

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.wvlet.airframe" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.wvlet.airframe" }
}]
labels: library-update

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request systematically updates the org.wvlet.airframe library dependencies across multiple example projects to their latest patch version, 2025.1.23. This ensures that the examples remain current with the Airframe ecosystem, benefiting from any recent stability improvements or minor feature enhancements in the updated libraries.

Highlights

  • Dependency Updates: The pull request updates several org.wvlet.airframe dependencies, including airframe-http, airframe-http-netty, airframe-launcher, airframe-rx-html, and sbt-airframe, from version 2025.1.22 to 2025.1.23.
  • Example Project Configuration: The AIRFRAME_VERSION variable and the sbt-airframe plugin version have been updated in the build.sbt and project/plugins.sbt files across various example projects, such as hello-rpc, rpc-scalajs, and rx-demo/gallery.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Airframe dependencies to version 2025.1.23 across several example projects. The changes are straightforward version bumps. My review focuses on improving the maintainability of the build files. I've noticed that the Airframe version is duplicated in build.sbt and project/plugins.sbt for some of the example projects. I've left comments with suggestions to centralize the version definition to avoid potential inconsistencies in the future. Other than that, the changes look good.

@@ -1,4 +1,4 @@
val AIRFRAME_VERSION = "2025.1.22"
val AIRFRAME_VERSION = "2025.1.23"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The AIRFRAME_VERSION is defined here and also hardcoded in project/plugins.sbt. This duplication can cause issues when updating versions. It would be more maintainable to define the version in a single place, for example, in a project/Versions.scala file, and then reference it in both build.sbt and plugins.sbt.


addSbtPlugin("org.xerial.sbt" % "sbt-pack" % "0.23")
addSbtPlugin("org.wvlet.airframe" % "sbt-airframe" % "2025.1.22")
addSbtPlugin("org.wvlet.airframe" % "sbt-airframe" % "2025.1.23")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Airframe version is hardcoded here, and also in the main build.sbt file. This duplication makes version management error-prone. I recommend centralizing the version definition. A common approach is to define it in a Scala object under the project/ directory and use that value in both places.

Global / onChangedBuildSource := ReloadOnSourceChanges

val AIRFRAME_VERSION = "2025.1.22"
val AIRFRAME_VERSION = "2025.1.23"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The AIRFRAME_VERSION is defined here and also hardcoded in project/plugins.sbt. This duplication can cause issues when updating versions. It would be more maintainable to define the version in a single place, for example, in a project/Versions.scala file, and then reference it in both build.sbt and plugins.sbt.

ThisBuild / libraryDependencySchemes += "org.scala-lang.modules" %% "scala-xml" % "always"

addSbtPlugin("org.wvlet.airframe" % "sbt-airframe" % "2025.1.22")
addSbtPlugin("org.wvlet.airframe" % "sbt-airframe" % "2025.1.23")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Airframe version is hardcoded here, and also in the main build.sbt file. This duplication makes version management error-prone. I recommend centralizing the version definition. A common approach is to define it in a Scala object under the project/ directory and use that value in both places.

@xerial
xerial merged commit b5a5c75 into main Jan 6, 2026
28 checks passed
@xerial
xerial deleted the update/airframe-http-2025.1.23 branch January 6, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants