fix: Add explicit permissions to GitHub Actions workflows - #4175
Merged
Conversation
Restrict the default GITHUB_TOKEN to least-privilege scopes for every workflow, addressing the 25 open `actions/missing-workflow-permissions` code-scanning alerts at https://github.com/wvlet/airframe/security. Most workflows only need `contents: read`. Exceptions: - `test.yml` adds `checks: write` for `mikepenz/action-junit-report` to publish check annotations. - `release-note.yml` uses `contents: write` so `gh release create` can publish the release. `doc.yml` keeps `contents: read` because the gh-pages push uses the `GIT_DEPLOY_KEY` SSH key, not GITHUB_TOKEN.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
permissionsblocks to all GitHub Actions workflows that were missing them, resolving the 25 openactions/missing-workflow-permissionsalerts at https://github.com/wvlet/airframe/security/code-scanningcontents: readonlytest.ymlalso getschecks: write(required bymikepenz/action-junit-reportfor check annotations)release-note.ymlgetscontents: write(required bygh release create)doc.ymlstays read-only — the gh-pages push uses theGIT_DEPLOY_KEYSSH key, notGITHUB_TOKENTest plan
Publish Test Reportannotations still appear on PRsrelease-note.ymlstill successfully creates a release